PATCH can be replaced by POST with X-HTTP-Method-Override PATCH#188
Open
YassinHajaj wants to merge 5 commits into
Open
PATCH can be replaced by POST with X-HTTP-Method-Override PATCH#188YassinHajaj wants to merge 5 commits into
YassinHajaj wants to merge 5 commits into
Conversation
Adding the request body's content with application/offset+octet-stream
PATCH can be replaced by POST with X-HTTP-Method-Override PATCH
Contributor
Author
|
I'll fix the failing linter problem |
Contributor
Author
|
Ok, it seems the linter is failing for months now. |
Member
|
Thank you, but I am wondering if this could also be achieved without copying the definition of the PATCH method? This duplicates a lot of code, which I would like to avoid. |
Contributor
Author
|
Sure, I'll look into it. |
Member
|
Great, let me know if you find something suitable! |
Member
|
@YassinHajaj Did you have any success with this so far? |
Contributor
Author
|
Hey @Acconut , No, I'm sorry. |
Member
|
That you for the headsup! |
Contributor
Author
|
Hi @Acconut , what's happening with this PR ? Should it be merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH can be replaced by POST with X-HTTP-Method-Override PATCH